ground-x / caver-js-ext-kas

Apache License 2.0
13 stars 15 forks source link

Applied wallet yaml latest and modified logic for krn #117

Closed jimni1222 closed 3 years ago

jimni1222 commented 3 years ago

Proposed changes

This PR introduces wallet yaml latest file. Also with some API there are some changes with x-krn. So with caver.kas.wallet.signMessage, krn paramter is removed and with caver.kas.wallet.getAccountCountByKRN, krn parameter is changed to optional parameter. For now, user cannnot define x-krn separately to get account counting(KAS not support that), throw error if user define krn.

Types of changes

Please put an x in the boxes related to your change.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Related issues

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...