ground-x / caver-js-ext-kas

Apache License 2.0
13 stars 15 forks source link

In memory wallet integration #53

Closed jimni1222 closed 3 years ago

jimni1222 commented 3 years ago

Proposed changes

This PR introduces the implementation of the integration of the in-memory wallet and KAS Wallet API service and the draft of the test code.

The link to KASWallet in README.md and to npm link of caver-js v1.0.2 do not exist because it has not yet been released. After the official version is released, the link will work normally.

This PR includes only the unit test of KasWallet. After this, i plan to implement integration tests to make sure work well with KAS Wallet API Service. Also, there may be additional implementations if we need additional function support.

Once this version is released, the in-memory wallet can no longer be used in CaverExtKAS.

Types of changes

Please put an x in the boxes related to your change.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Related issues

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...