This PR contains some additional logic in kasWallet.
Added default number(1) with caver.wallet.generate
When checking accountKey, if accountKey is null, accountKey is not checked.
Exception handling has been added so that legacy transactions can also be used.
When using a global fee, the logic has been changed to allow appending feePayerSignatures. The existing logic of signAsGlobalFeePayer returned an error if the fee payer was defined in the transaction, but the logic was added/modified to operate to be able to append for the same global fee payer.
After this PR in mergered, i will upload integration test PR.
Types of changes
Please put an x in the boxes related to your change.
[ ] Bugfix
[x] New feature or enhancement
[ ] Others
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules
Related issues
Please leave the issue numbers or links related to this PR here.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Proposed changes
This PR contains some additional logic in kasWallet.
caver.wallet.generatesignAsGlobalFeePayerreturned an error if the fee payer was defined in the transaction, but the logic was added/modified to operate to be able to append for the same global fee payer.After this PR in mergered, i will upload integration test PR.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...