This PR introduces the addition of the Keyring module to be accessed through an instance of KeyringContainer. Also you can access keyring through caver.keyringContainer
The usability of the existing caver.wallet.keyring is maintained, but it is unnatural to access Keyring through KASWallet.
So, if the user uses keyringContainer separately, i will guide user to access the keyring module through the keyringContainer instance.
Types of changes
Please put an x in the boxes related to your change.
[ ] Bugfix
[x] New feature or enhancement
[ ] Others
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules
Related issues
Please leave the issue numbers or links related to this PR here.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Proposed changes
This PR introduces the addition of the Keyring module to be accessed through an instance of KeyringContainer. Also you can access keyring through
caver.keyringContainerThe usability of the existing
caver.wallet.keyringis maintained, but it is unnatural to access Keyring through KASWallet. So, if the user uses keyringContainer separately, i will guide user to access the keyring module through the keyringContainer instance.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...