all changes from 3s are included

groundcherry / bluebottle-3.0

A many-GPU-centric two phase flow simulation code implementing the Physalis method

Apache License 2.0

10 stars 6 forks source link

all changes from 3s are included #4

Closed yu-H-ang closed 3 years ago

yu-H-ang commented 3 years ago

maybe this should be merged to a new branch

ajsierakowski commented 3 years ago

Hey, @dwille, this is a pretty cool feature. It looks like good work to me. Would you be able to find a few minutes to give it a quick sanity check?

dwille commented 3 years ago

@yu-H-ang - can you take a look at the comments and address in another pull request if you think they're necessary? I'll merge this now, though.

yu-H-ang commented 3 years ago

Quite sorry I didn't reply in time. I hope you will understand that this is not a priority after graduation. Hope those comments are helpful and hope you guys all good. Cheers.

ajsierakowski commented 3 years ago

Certainly! Thanks for the clarifications, @yu-H-ang.