groundhog2k / helm-charts

Helm charts for open source applications - ready to use for deployment on Kubernetes
MIT License
69 stars 56 forks source link

Add image registry option #1164

Closed GKotfis closed 2 years ago

GKotfis commented 2 years ago

Add image registry option to allow pull images from other registries (i.e., deployed to cluster)

groundhog2k commented 2 years ago

Why not simply overwriting the repository value with repository: my-registry.com/myrabbitmq during your deployment?

groundhog2k commented 2 years ago

I thought about your suggestion again and will adapt it and add it to all the charts after a few tests.

GKotfis commented 2 years ago

@groundhog2k We used in project bitnami helm chart, but we have problems on Mac M1 with their rabbitmq image. That's why I started to look for other helm chart which use official rabbitmq images.

https://github.com/bitnami/charts/tree/master/bitnami/rabbitmq#rabbitmq-image-parameters

groundhog2k commented 2 years ago

I took your idea and rolled it out to all charts :-) (https://github.com/groundhog2k/helm-charts/pull/1169/commits/2f4d393d4b3b323b26d87aa933ce48c4766e8049)

Thank you!