search

groundhog2k / helm-charts

Helm charts for open source applications - ready to use for deployment on Kubernetes
MIT License
69 stars 56 forks source link

Redis Deployment vs Statefulset #1209

Closed tim-hanssen closed 1 year ago

tim-hanssen commented 1 year ago

Hey @groundhog2k

Would you consider support for the Redis chart to be deployed as a Deployment instead of the current StatefulSet?

For our "non-critical" Redis setups where HA mode is disabled the StatefullSet is giving issues when the Node becomes unavailable. Because the StatefulSet remains in "terminating" state until the node comes back up, the instance is not transferred to another node. We don't mind the data loss, since we also switched disk saving off.

Other suggestions are welcome too.

groundhog2k commented 1 year ago

I understand the problem related to the StatfulSet behavior and can reproduce it. I will check what I can do here. Maybe I will add another option to the helm charts values file to switch between Deployment and StatefulSet when HA mode is disabled.

groundhog2k commented 1 year ago

@tim-hanssen : Please have a look at the PR I uploaded for test. I think this is what you had in mind.

tim-hanssen commented 1 year ago

@groundhog2k seems fine! This should work and I guess is also a more safer method for the non-ha. Nice!