search

groupby / hubot-hangups

Hubot adapter using hangups
39 stars 3 forks source link

Fix #7 : Support hyperlinks #11

Closed joybro closed 9 years ago

joybro commented 9 years ago

This fixes issue #7. hangups.ChatMessageSegment.from_str parses given text and makes link work.

codeallthethingz commented 9 years ago

@joybro awesome! This is our first community patch. @ehacke is there a unit test suite for this class and if not can we create one before this is merged?

ehacke commented 9 years ago

@joybro thanks! @willwarren no unit testing at the moment because 95% of the code came from other places, none of it with unit testing.

I had planned on looking at the project today, so I'll merge this, test it, and try to get an all-in-one installer built.

codeallthethingz commented 9 years ago

OK. But make maidi do it!

ehacke commented 9 years ago

@willwarren yup, will do.

joybro commented 9 years ago

@ehacke @willwarren I rebased my patch so that it could be merged without conflict. Thank you for good project. I like hubot-hangups :)

ehacke commented 9 years ago

@joybro thanks alot, I was about to mention that. I'll have @l3ubbleman merge it tomorrow morning.

ehacke commented 9 years ago

Testing created in separate branch, will merge that next.