search

groupe-sii / sonar-web-frontend-plugin

Sonar plugin to add metrics for web technologies (JS, CSS, HTML, SASS, AngularJS...)
Apache License 2.0
115 stars 26 forks source link

[question] Support for SonarQube 5.6 #30

Open tristanlins opened 8 years ago

tristanlins commented 8 years ago

SonarQube 5.6 LTS is released some days ago. Are there any plans / timeline to support the new version?

rmalveis commented 8 years ago

+1

aurelien-baudet commented 8 years ago

Sonar has made big changes on plugin APIs and some APIs are no longer available or working as before. For example, code duplication API is no more available. Now, if you want to support a language you have to provide a lexer based on SSLR. If you don't do that, you can't set information about the file metrics (number of lines, number of line of comments, number of line of code...). I think that our plugin could be adapted quickly (code is quite simple and just simplifies calls to Sonar APIs) but the most difficult part is to understand and find a way to make features still working correctly with Sonar 5.6+.

For now, I tried to find solutions to make it work with Sonar 5.5. I didn't try for Sonar 5.6. We will try it but I don't know when and I can't ensure that it will be possible.

But it is an open source project so you could also try yourself and I will be pleased to have external contributors.

mattadamson commented 8 years ago

Hi @aurelien-baudet I'm very excited to see this plug in and also a little disappointed it won't work with 5.6. We are also looking to move to Sonar 5.6 LTS. On reviewing 5.5 did you find some of the standard rule violations will work correctly e.g. for eslint? I wonder if we can at least support a subset of the analysis and allow the others to be disabled whilst we work on getting the other report types imported.

Thoughts?

mattadamson commented 8 years ago

I noticed most of the reports are configurable so perhaps it does work in 5.6 for importing some linters such as eslint reports if others are turned off which don't work.

merjadok commented 7 years ago

Hello,

thank you for the great plugin!

After upgrading to Sonar version 5.6 we have experienced some problems so I wanted to check whether it is still the case that 5.6 version is not supported?

Also, we are now having a multi-module project: is this supported by the plugin?

Thanks in advance!

NikitaEgorov commented 7 years ago

Try to use https://github.com/Pablissimo/SonarTsPlugin

fsmaia commented 7 years ago

Hi @aurelien-baudet! Thanks for explanation about Sonar 5.6.

I'm running Sonar 5.5 with SonarScanner 2.8 (by gulp-sonar@3.0.0) and generating reports with sonar-web-frontend-reporters and JSCPD with gulp-jscpd@0.0.6.

However the duplication reports aren't reaching Sonar.

Do you know if this can be related to code duplication API deprecation?

Thanks in advance!

noomidian commented 7 years ago

@fsmaia @aurelien-baudet already answered this question in a previous post (see above) It seems that he is pretty muched occupied this days. About the problem of duplications, we have the same problem, we generate the js-duplication.xml with the sii reporter, the file is read and added to sonar api measures but the measures do not displays in the sonar interface (btw, we use the 5.6 release). I tried to debug quickly but i didn't notice something strange.

Btw, @aurelien-baudet, i did a pull request to correct a problem of regexp we encountered with the java plugin and Sonar 5.6 (the code resolved our problem).

We also did corrections in the reporters, i'll try to do a pull request for it this week.

cedric-legallo commented 7 years ago

We also did corrections in the reporters, i'll try to do a pull request for it this

week.

I have a bit more spare time than Aurelien has, so this one should be merged quickly. One day i'll dig in the plugin code enough to review and merge PR but i neither do have enough time for that ATM, so you'll have to wait for Aurelien to do it.

rusboy commented 7 years ago

+100500

rusboy commented 7 years ago

Hey Guys, Can you explain why your excluded importing for native eslint rules from sonar-5.x branches (I'm observing only angular-eslint)?

Your tool looks good, however I need it with SonarQube 5.6....

I have an idea, to make the plugin works with SonarQube 5.6. Will be useful, if you share your experience and found issues

Regards, Ruslan

CedricLeGallo commented 7 years ago

Native eslint rules should be included. You have to configure your Sonar Rules to activate or deactivate ruleset. If the defaultruleset exclude them you can tune them in sonar.

The sure thing is the reporters report them. The main issue with upgrading the plugin for more recent sonar version is the pure removal by sonar of some API we used and don't have alternative anymore to display this informations.