groupeLIAMG / ttcr

Codes to do raytracing for geophysical applications
GNU General Public License v3.0
85 stars 33 forks source link

Reimplement the method projectOnFace when the gradient fall on an edge #40

Closed maher-nasr closed 3 years ago

maher-nasr commented 3 years ago
maher-nasr commented 3 years ago

Hi Bernard; Yes, I've noticed that no changes were made to my branch too. It’s maybe because I didn’t commit the changes. I will try a new push/pull request.

On May 1, 2021, at 1:13 PM, Bernard Giroux @.**@.>> wrote:

Attention : ce courriel provient d'un expéditeur externe.

@bernard-giroux requested changes on this pull request.

Hi Maher,

I find only 1 change in the pull request (file boost_1_72_0/boost/asio/detail/throw_exception.hpp deleted, commit d45640ahttps://github.com/groupeLIAMG/ttcr/commit/d45640a5721ad5a8ef32966dd6b50ce049c2564f), which is not related to projectOnFace. I have no issue compiling with this file in the build tree... Please undo commit d45640ahttps://github.com/groupeLIAMG/ttcr/commit/d45640a5721ad5a8ef32966dd6b50ce049c2564f and verify your installation. Also commit the changes to projectOnFace

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/groupeLIAMG/ttcr/pull/40#pullrequestreview-649803187, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEHQBX3A44T5MR5F6BPJZT3TLQZD5ANCNFSM435TR4AQ.