search

groupgets / GetThermal

Cross-platform USB thermal camera viewer
MIT License
228 stars 90 forks source link

minPoint and maxPoint not properly mapped in dataformatter.cpp #34

Closed 2ynn closed 3 years ago

2ynn commented 3 years ago

https://github.com/groupgets/GetThermal/blob/661a519a43a9c150ae1de487e50b60db7ce8306c/src/dataformatter.cpp#L47-L72

i sweeps through the input's height (y direction) and j its width (x)

values passed to setX() and setY() should then be inverted

Thanks!

kekiefer commented 3 years ago

It looks like you're right, could you send a pull request?

2ynn commented 3 years ago

OK, will do. Should I add a Q_PROPERTY and plot maxPoint in the UI as a validation? qynn

Sep. 24, 2020, 6:27 p.m. by notifications@github.com:

It looks like you're right, could you send a pull request?

— You are receiving this because you authored the thread. Reply to this email directly, > view it on GitHub https://github.com/groupgets/GetThermal/issues/34#issuecomment-698620574> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AJ65UUBWOTMNZICQ43GRKOTSHPBVLANCNFSM4RY2YGLA> .

kekiefer commented 3 years ago

Sure, that would be great!

kekiefer commented 3 years ago

Closed via #35