check crc, line numbers, throw exception after too many resets

groupgets / pylepton

Quick and dirty pure python library for interfacing with FLIR lepton

MIT License

208 stars 94 forks source link

check crc, line numbers, throw exception after too many resets #13

Closed sanktnelson closed 2 years ago

sanktnelson commented 7 years ago

changed Lepton.py to:

check all line numbers ( not just 20 ) after whole frame is read
check crc after whole frame is read
allow configurable number of retries so pylepton does not wait forever for a frame

sorry, this is still for the old python2 code. I'm new to GIT and github and just wanted to get this code out there since it fixes some glaring omissions in the original.

kekiefer commented 7 years ago

Thanks for taking the time to send this over. This really needs to be reworked to not revert other recent fixes to the code. Some general advise for submitting pull requests (and git in general):

make one change per commit. If you're changing a few things, make a few commits. Your pull request will group all these together
don't commit whitespace changes, or trivial changes unrelated to what you want to send
One way to be selective in what you stage for commit with git add -p

sanktnelson commented 7 years ago

Thanks for the advice and again please excuse the bad patch. The thing is, we use subversion internally and I won't have time to get into git for months at least, so I submitted it via the github webinterface in the hope that that is still more useful than not doing anything

blubberdiblub commented 7 years ago

Instead of changing the code from Python 3.x to 2.x, you could add code to make it compatible with both 2.7 and 3.x (ideally in a separate pull request).

For instance in Python 2.7 you can use from __future__ import absolute_import so you don't have to change the imports. This future import will also be accepted in Python 3.x, it will just do nothing there, so there's not even a need to branch by version in this case.