groupgets / pylepton

Quick and dirty pure python library for interfacing with FLIR lepton
MIT License
208 stars 93 forks source link

python3 fixes #66

Closed krasi-georgiev closed 2 years ago

krasi-georgiev commented 2 years ago

Signed-off-by: Krasi Georgiev 8903888+krasi-georgiev@users.noreply.github.com

kekiefer commented 2 years ago

Looks fine, thanks for the updates! Just one comment/question in-line for my understanding.

krasi-georgiev commented 2 years ago

I don't see the comment?

kekiefer commented 2 years ago

The change to SPIDEV_MESSAGE_LIMIT here: https://github.com/groupgets/pylepton/pull/66/files/2b99821c16059aab68d49451b538e430fbfbabf6#diff-cd294a51811e671f3ed3f8d662b4441f1a96a5466358a0f0c525224e6ab3b51eR47

krasi-georgiev commented 2 years ago

Without this I was getting OSError: [Errno 90] Message too long and non of the suggested fixes I found for increasing the limit worked

krasi-georgiev commented 2 years ago

more details here

https://github.com/groupgets/pylepton/issues/52

kekiefer commented 2 years ago

OK, IIRC this larger message size used to be required to work with Lepton 3 (at least when this was initially put together for rpi 3).

The comment suggests increasing /sys/module/spidev/parameters/bufsiz to get around this limit, did this not work, or was it just simpler to have small SPI messages?

If this works with Lepton 3.5 on rpi 4, I guess I'm OK with it as it's just one less thing to have to set up.

krasi-georgiev commented 2 years ago

I am running this on Rpi3 with lepton 3.5 and it works

kekiefer commented 2 years ago

Alright then, even better. In that case thanks again for the updates!

krasi-georgiev commented 2 years ago

26-Jan-21:35:31 59