search

groupme-js / node-groupme

The only GroupMe API library for NodeJS that isn't a million years old.
https://groupme.js.org
MIT License
27 stars 11 forks source link

Add support for creating groups #91

Closed striker4150 closed 2 years ago

striker4150 commented 2 years ago

Resolves #7.

thewilloftheshadow commented 2 years ago

Test failure was due to the fact it was running on a fork with no access to the testing account

not-so-smart commented 2 years ago

Test failure was due to the fact it was running on a fork with no access to the testing account

yeah lol this is a bit of a problem, I feel like we should make it so that either the tests don't run on forks at all, or make it so that org members can manually run the tests on a pr after checking out the code if that's possible

thewilloftheshadow commented 2 years ago

Done, #92

striker4150 commented 2 years ago

I made the changes as requested. Let me know if you have any other suggestions.

not-so-smart commented 2 years ago

before we merge this, @thewilloftheshadow can you double check why the tests failed? I approved the actions to run but either the auth token didn't get shared or some test genuinely didn't pass. I also couldn't access the logs from this run for some reason, maybe you can get them somehow.

thewilloftheshadow commented 2 years ago

Yeah I can see the logs, it's from how I have them setup, I need to change some things. You can go ahead and merge

ngm-bot commented 2 years ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: