search

groupon / FeatureAdapter

FeatureAdapter (FA) is an Android Library providing an optimized way to display complex screens on Android.
Apache License 2.0
113 stars 12 forks source link

NPE on Collections.unmodifiableList #34

Closed ciprimare closed 5 years ago

ciprimare commented 5 years ago

Fixes issue #33

codecov[bot] commented 5 years ago

Codecov Report

Merging #34 into master will increase coverage by 0.66%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
+ Coverage     64.12%   64.79%   +0.66%     
- Complexity       79       82       +3     
============================================
  Files            14       14              
  Lines           407      409       +2     
  Branches         46       47       +1     
============================================
+ Hits            261      265       +4     
+ Misses          138      137       -1     
+ Partials          8        7       -1
Impacted Files Coverage Δ Complexity Δ
...va/com/groupon/featureadapter/FeaturesAdapter.java 70.32% <66.66%> (+1.79%) 22 <0> (+2) :arrow_up:
.../java/com/groupon/featureadapter/FeatureItems.java 95.65% <0%> (+4.34%) 9% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b1fd64...b45ed42. Read the comment docs.

stephanenicolas commented 5 years ago

RTM after testing in MGA