groupon / Selenium-Grid-Extras

Simplify the management of the Selenium Grid Nodes and stabilize said nodes by cleaning up the test environment after the build has been completed
BSD 3-Clause "New" or "Revised" License
537 stars 210 forks source link

Easily Support Edge WebDriver Download #219

Open Chris2m opened 8 years ago

Chris2m commented 8 years ago

For Chrome and IE selenium-grid-extras supports the automatic download of webdrivers. For Edge this capability is missing. Now there is an easy way of setting up EdgeWebdriver:

EdgeDriverManager.getInstance().setup();

For more details see: http://stackoverflow.com/a/33461095

smccarthy commented 8 years ago

I am not a fan of the method used in that project you linked. It uses the HTMLUnit driver to go to the page and download it. Plus it seems like it just goes to the latest URL that is given in the config file. So our auto update for EdgeDriver would depend on that other project to update their config file. Please let me know if I missed anything. I will still think of ideas for this.

smccarthy commented 8 years ago

I asked someone at Microsoft if there is a link to the latest version and he sent me this link : https://download.microsoft.com/download/1/4/1/14156DA0-D40F-460A-B14D-1B264CA081A5/MicrosoftWebDriver.exe

However, that doesn't give us a version number. One thing we could do, is auto-download it each time. It is under 1MB, so wouldn't be that terrible. Anyone else have ideas?

mstankovic86 commented 8 years ago

I think that's not good idea because there are different drivers for different versions of Windows

https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver/

smccarthy commented 8 years ago

@mstankovic86 Oh ok, thanks for the heads up.

smccarthy commented 8 years ago

Another solution, is instead of having the auto-upgrade of the EdgeDriver, we could ask the user what version of Edge do they have (or guess it, like we do for Chrome and Firefox), and download the corresponding EdgeDriver from https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver/ .

mstankovic86 commented 8 years ago

that would be great!

smccarthy commented 8 years ago

If anyone is available to work on this, please feel free. I can post back here when I find time, but it probably won't be for a few weeks.

travisneedham commented 7 years ago

Any update on this?