search

groupon / Selenium-Grid-Extras

Simplify the management of the Selenium Grid Nodes and stabilize said nodes by cleaning up the test environment after the build has been completed
BSD 3-Clause "New" or "Revised" License
536 stars 209 forks source link

using HTMLUnit driver ? #245

Open vsraptor opened 8 years ago

vsraptor commented 8 years ago

how to add htmlunit driver, so I can use it with sg-extra ?

Following : https://github.com/SeleniumHQ/htmlunit-driver

I tried to modify node_5555.bat, but it seems this file is created on the fly (i.e. overrides my changes).

Any other ideas ? Where do I put a path to htmlunit-standalone-jar so it integrate support for it in sg-extra ?

thanks

smccarthy commented 8 years ago

I don't think adding htmlunit driver to selenium grid extras is a good idea. Why do you want htmlunit ?

smccarthy commented 8 years ago

Actually, that node file is not generated on the fly. It could be pulled from the hub if you have that setup. Update it in the hub in that case

vsraptor commented 8 years ago

You mean in some jar file ? (any tool for manipulating/updating jar files?)

vsraptor commented 8 years ago

Some tests are "flunking" and want to run them via htmlunit. Why do you say it is not a good idea ?

smccarthy commented 8 years ago

@vsraptor Sorry I responded via my phone earlier, so I think I didn't come across as clear.

I don't think the node config or bat files are generated automatically (I know the config isn't for sure, and pretty sure the bat file isn't either). The config files could be pulled down from the hub on startup of grid-extras (if you are storing them in a central location).

I am against HtmlUnit since real users don't use it. I noticed it isn't included in the main selenium package anymore, according to https://github.com/SeleniumHQ/htmlunit-driver , so not sure it will work with Selenium-Grid-Extras right now. I suggest trying to see why the chrome or firefox or IE tests are failing before you try and move to HtmlUnitDriver.

vsraptor commented 8 years ago

When I modify node_555.bat and run SGE it does not use my modifications, but overrides is with generated file. I get both "you file has been updated in my editor" and I can see the in cmd-line console that htmunit-configuration is not part of the parameters. And I don't see options in node_555.json where I can append more libraries i.e. htmlunit.