search

groupon / Selenium-Grid-Extras

Simplify the management of the Selenium Grid Nodes and stabilize said nodes by cleaning up the test environment after the build has been completed
BSD 3-Clause "New" or "Revised" License
537 stars 210 forks source link

Unable to get videos in video-output folder/hyperlink in the hub url #251

Open hemanthsridhar opened 8 years ago

hemanthsridhar commented 8 years ago

OS : MAC grid extras version : 1.12.3 Running my machine as a hub and a node

My Tests Run smoothly and finishes properly. The only problem is even though the video is enabled, I am not finding it as a link in the hub url. I am not getting it in video_output folder either. Let me know if I have missed out on anything to add.

Selenium grid config json

{ "theConfigMap": { "auto_update_browser_versions": "1", "hub_config_files": [ "hub_4444.json" ], "auto_start_hub": "1", "iedriver": {}, "default_role": "hub", "chromedriver": { "bit": "64", "version": "2.23" }, "auto_update_drivers": "1", "video_recording_options": { "videos_to_keep": "150" }, "auto_start_node": "1", "hub_config": {}, "geckodriver": { "version": "0.0.0" }, "log_maximum_age_ms": 864000000, "webdriver": { "version": "2.53.1" }, "node_config_files": [ "node_5555.json" ] } }

hub json

{ "port": 4444, "newSessionWaitTimeout": 25000, "servlets": [ "com.groupon.seleniumgridextras.grid.servlets.SeleniumGridExtrasServlet", "com.groupon.seleniumgridextras.grid.servlets.ProxyStatusJsonServlet" ], "capabilityMatcher": "org.openqa.grid.internal.utils.DefaultCapabilityMatcher", "throwOnCapabilityNotPresent": true, "nodePolling": 5000, "cleanUpCycle": 5000, "browserTimeout": 120000, "timeout": 120000, "maxSession": 5 }

node json

{ "capabilities": [ { "seleniumProtocol": "WebDriver", "browserName": "firefox", "maxInstances": 3, "version": "47", "platform": "MAC" }, { "seleniumProtocol": "WebDriver", "browserName": "chrome", "maxInstances": 3, "version": "53", "platform": "MAC" }, { "seleniumProtocol": "WebDriver", "browserName": "safari", "maxInstances": 3, "version": "", "platform": "MAC" } ], "configuration": { "proxy": "com.groupon.seleniumgridextras.grid.proxies.SetupTeardownProxy", "maxSession": 3, "port": 5555, "register": true, "unregisterIfStillDownAfter": 10000, "hubPort": 4444, "hubHost": "127.0.0.1", "nodeStatusCheckTimeout": 10000, "downPollingLimit": 0 }, "loadedFromFile": "node_5555.json" }

smccarthy commented 8 years ago

@hemanthsridhar So the video links are not appearing on your hub grid extras dashboard? I believe the videos should transfer from the nodes to the hub after each test run, but I noticed it not happening as well. Is this the issue you are seeing too?

hemanthsridhar commented 8 years ago

yes @smccarthy

hemanthsridhar commented 7 years ago

any update on this ?

LazyPotato commented 7 years ago

@hemanthsridhar @smccarthy , maybe the problem is in this pull request https://github.com/groupon/Selenium-Grid-Extras/pull/198/commits? If the hub and the node are on the same machine (RuntimeConfig.getConfig().getAutoStartHub() && RuntimeConfig.getConfig().getAutoStartNode() is true), VideoDownloaderCallable is not called at all. I have split them in two different folders (having a hub and a node separately) and it works as expected. This is still a bug though, should i create an issue?

hemanthsridhar commented 7 years ago

@LazyPotato : I definitely think that this is bug. @smccarthy right person to answer this.

mikeblakeuk commented 7 years ago

Any news on this. I guess the extra, grid hub and node should be on different machines?