groupon / Selenium-Grid-Extras

Simplify the management of the Selenium Grid Nodes and stabilize said nodes by cleaning up the test environment after the build has been completed
BSD 3-Clause "New" or "Revised" License
537 stars 210 forks source link

Extended configurations for selenium: #298

Open vveliev opened 7 years ago

vveliev commented 7 years ago

I'm trying to pass custom location of firefox but unable to do that.

Selenium supports 2 ways of adding extra configs:

  1. pass as inline parameter :
    java -jar "selenium-server-standalone-3.0.0.jar" -Dwebdriver.firefox.bin="/opt/firefox/firefox-bin"
  2. Use node/hub Json config file:
    {
    "capabilities": [
    {
      "browserName": "firefox",
      "maxInstances": 8,
      "version": "49",
      "seleniumProtocol": "WebDriver"
    }
    ],
    "Dwebdriver.firefox.bin=/opt/firefox/firefox-bin": "",
    "Dwebdriver.chrome.driver=/usr/share/chrome-webdriver/chromedriver": "",
    "maxSession": 10,
    "port": 5555,
    ...
    }

    Using Json config file does not work , and i'm not sure if selenium grid extra supports extra inline params to be passed to selenium

probably related to #296

smccarthy commented 7 years ago

@vveliev I am not sure this falls in the line of Selenium Grid Extras (I could be wrong). Selenium Grid Extras created the config file, but after that, it just reads it. So you should be able to add anything to the node config file that you could without selenium grid extras.

There is a known issue where new items added to the config file are being removed, but I think it is only when upgrading from Selenium 2 to Selenium 3 (since the format of the node file changed, I just read the parameters we initially put into the config file, and put them in the new config file in the right format).

Have you tried using the same node config file without selenium grid extras?