search

groupon / assertive

Assertive is a terse yet expressive assertion library
BSD 3-Clause "New" or "Revised" License
21 stars 11 forks source link

sane printouts of Symbols in assertion errors #14

Closed johan closed 9 years ago

johan commented 9 years ago

A quick fix for #13 for @jkrems.

Suggestions or PR:s to add Travis magic to invoke tests that produce Symbols would be appreciated; seems we might need to run on iojs for this one, at the moment.

ghost commented 9 years ago

The joys of being at the bleeding edge :smiley:

jkrems commented 9 years ago

:heart:

jkrems commented 9 years ago

P.S.: I think travis is using nvm internally (it used to at least), so once they upgraded nvm to >=0.28.0 we should be able to add it to the config.

johan commented 9 years ago

Currently they apparently are at nvm 0.20.0 (at least when running with our current node 0.10 setup, which gets node v0.10.36, npm 1.4.28).

Lacking tests: does this branch seem to solve your current problems? If so, I'm cool making a tactical release now to unblock you.

jkrems commented 9 years ago

I'm definitely not blocked by this. It's at most a minor inconvenience in a pet project for me. And I have a sane work-around. I'd vote for letting this PR hang until travis adds support. Apparently they are "working on it" and I'd expect support to land soon.

See: https://github.com/travis-ci/travis-ci/issues/3108

johan commented 9 years ago

:+1: Sounds good to me.

jkrems commented 9 years ago

I'm assuming this can be closed due to #16 landing?

johan commented 9 years ago

Totally — thanks!