search

groupon / assertive

Assertive is a terse yet expressive assertion library
BSD 3-Clause "New" or "Revised" License
21 stars 11 forks source link

replace underscore & redux with lodash & coffee-script #21

Closed ghost closed 9 years ago

ghost commented 9 years ago

Just felt like cleaning up shop a bit - what do you think @johan?

johan commented 9 years ago

Splendid idea! :+1: Would be good not to duplicate the license, though. The first one has a /*! prefix, the second a /* one. I don't know if we have any rules of engagement for that to abide by, but if not, maybe just the second is good?

The manual Makefile pokery I hacked up long ago to comply with asks at the time probably could be torn out and replaced with something standardized.

ghost commented 9 years ago

Fixed make build duplicating the license twice - I can look at switching the Makefile over to package.json scripts & npub later today if that sounds good with you.

johan commented 9 years ago

:ship: Sweet! I'd love npub to take over those bits.

Do you have the bits required to publish assertive? I can't recall we've tested that so far, and it would be nice to proof that we have good bus factor mitigation in place already for assertive.

ghost commented 9 years ago

Aside from you, Massa does:

$ npm owner ls assertive
smassa
ecmanaut

We did set up a groupon user awhile ago, although it hasn't got much use yet :smiley:. We should really start using it...

$ npm owner add groupon assertive
johan commented 9 years ago

Perfect. Added; take it away! :)

ghost commented 9 years ago

Can't publish due to some bash error in Makefile - I'm using Ubuntu 14.04 BTW.

I'll make the npub change tonight and submit a PR - then I can publish.

ghost commented 9 years ago

v2.0.1