Closed rduenasf closed 9 years ago
Thanks! I'd personally say that adding a test for this might be out of scope of this PR (since it would kind of require running our tests on CI in phantomjs). LGTM!
(Deferring the merge & release to @khoomeister since he's already on it.)
:+1: here too, and copying that. :)
Hey @rduenasf, sorry can you rebase against latest? The js file is probably the only thing that'll complain since we switched from redux back to normal coffeescript.
@khoomeister done :+1:
Thanks!
Published as v2.0.2
Issue: While using
assertive
withPhantomJS 1.9.X
, I was getting the following errors:Cause:
PhantomJS 1.9.X
doesn't supportECMAScript 5
, therefore doesn't supportbind
, causing the failure.Solution: Replace
bind
for_.partial
Notes: I wasn't sure what kind of test to add for this kind of fix, any recommendations?