groupon / assertive

Assertive is a terse yet expressive assertion library
BSD 3-Clause "New" or "Revised" License
21 stars 11 forks source link

refactor: get rid of coffeescript #29

Closed dbushong closed 7 years ago

dbushong commented 7 years ago
aaarichter commented 7 years ago

there is an error being thrown when running test-client with node 6.x

not ok 1 PhantomJS 2.1 - Global error: SyntaxError: Unexpected token 'const' at http://localhost:7357/test/tmp/test-bundle.js, line 1310
    ---
        Log: |
            { type: 'error',
              text: 'SyntaxError: Unexpected token \'const\' at http://localhost:7357/test/tmp/test-bundle.js, line 1310\n' }
    ...

test-bundle.js:


},{}],16:[function(require,module,exports){
(function (process){
'use strict';

/*
...
*/

// eat _ off the global scope, or require it ourselves if missing
// eslint-disable-next-line no-new-func
const global = Function('return this')();
let assert;

// eslint-disable-next-line global-require
const _ = global._ || require('lodash');
...
dbushong commented 7 years ago

D'oh. OK, pin the old version for the moment - I guess we'll use babel ;;

dbushong commented 7 years ago

@aaarichter should be fix as of https://github.com/groupon/assertive/pull/31 - will ship in a sec

aaarichter commented 7 years ago

Hey David - no problem. A hint to use babel should do it too 😉

We will add babel to our js asset pipeline