refactor: drop Node 6/8 support; convert to ES6 & upgrade packages

groupon / assertive

Assertive is a terse yet expressive assertion library

BSD 3-Clause "New" or "Revised" License

21 stars 11 forks source link

refactor: drop Node 6/8 support; convert to ES6 & upgrade packages #49

Closed aaarichter closed 4 years ago

aaarichter commented 4 years ago

Breaking Change:

[x] refactor: drop Node 6/8 support
[x] refactor: remove babel transpiling to ES5

Usage with client test inside of ES5 browser like PhantomJS is no longer supported.

Changes

[x] chore: upgrade dependencies
[x] simplify eslint setting
[x] refactor: remove Bluebird

dbushong commented 4 years ago

i'd like the "remove babel transpilation" commit to mention that losing ES5 browser support is a breaking change

dbushong commented 4 years ago

Also, the bluebird-killing commit should mention that it's a breaking change that returned promises are no longer Bluebird promises (people might have written code that uses .spread() or whatnot)

dbushong commented 4 years ago

Also, the bluebird-killing commit should mention that it's a breaking change that returned promises are no longer Bluebird promises (people might have written code that uses .spread() or whatnot)

actually, scratch this, looks like the lib itself wasn't bluebird-wrapping; we were just using it in the tests

dbushong commented 4 years ago

Also, shall we take this major bump occasion to also drop node 8 support?

aaarichter commented 4 years ago

@dbushong

that losing ES5 browser support

The use case is client tests via testem and PhantomJS?

Also, shall we take this major bump occasion to also drop node 8 support?

sure why not.

dbushong commented 4 years ago

The use case is client tests via testem and PhantomJS?

Yeah, that's probably going to be the major stumbling block