The next major version of gofer

[jkrems]

Current Status

• [x] Gofer.fetch(uri), Gofer.fetch(uri, options), Gofer.fetch(uri, options, callback) are supported.
• [x] Gofer is the default export
• [x] config has global-, service-, and endpoint defaults
• [x] Endpoints functions can be written to support promise- and callback-usage.
• [x] When a callback is provided, it's used and fetch returns undefined.
• [x] It's possible to retrieve a Promise<Stream> and pipe it.
• [x] It throws when the baseUrl contains a query string.
• [x] baseUrl is just an option, there's no default option mapper.
• [x] clearOptionMappers doesn't exist.
• [x] The callback accepts three arguments: (error, data, response).
• [x] There is no gofer/hub.
• [x] The User-Agent is constructed from clientName and clientVersion.
• [x] Each client class gets its own agent that controls the maxSockets setting for that API.
• [x] options.body: It's possible to pass a readable stream.
• [x] options.body: It's possible to pass a buffer.
• [x] options.body: It's possible to pass a string.
• [x] options.method, uppercase HTTP method.
• [x] options.qs: Nested query string parameters
• [x] options.json: Object that will be serialized to JSON.
• [x] options.form: Object that will be serialized via qs to a form encoded body.
• [x] options.auth (string): Will be used to generate a basic auth header.
• [x] options.auth (object): username/password pair used to generate a basic auth header.
• [x] options.connectTimeout: Determines how long to wait for a successful TCP connection after acquiring a socket.
• [x] options.timeout: Determines how long to wait for response headers. Also controls the socket read timeout.
• [x] options.pathParams: Object with params that will be inserted into {placeholder}s in the URL.
• [x] Fail on missing path params, see https://github.com/groupon/gofer/issues/50
• [x] options.maxSockets: How many connections/sockets in parallel are allowed.
• [x] options.rejectUnauthorized: Same as node's own rejectUnauthorized.
• [x] options.headers: Works just like node's own headers option.
• [x] Provide example of using an option mapper (?) to support multi-part form bodies
• [x] Support for environments like browsers or React native where fetch is available

  Resources

• Implementation
• Planning doc with all the changes
• Original POC

[jkrems]

cc @dbushong @ageitgey There's now an - afaict - complete implementation on the jk-gofer-goes-fetch branch. It's one of those things that's really hard to review. Maybe David and I could sit down and go through it, looking for pending issues..?

[dbushong]

+1

David Bushong

On Mon, Apr 18, 2016 at 5:24 PM, Jan Olaf Krems notifications@github.com wrote:

cc @dbushong https://github.com/dbushong @ageitgey https://github.com/ageitgey There's now a - afaict - complete implementation on the jk-gofer-goes-fetch branch https://github.com/groupon/gofer/tree/jk-gofer-goes-fetch. It's one of those things that's really hard to review. Maybe David and I could sit down and go through it, looking for pending issues..?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/groupon/gofer/issues/49#issuecomment-211647636

[jkrems]

This is now set up as the 3.x branch. PRs against that branch will be released with a beta dist-tag to npm. PRs against master will be released with latest dist-tag (just like before). That way npm install gofer will install 2.x and npm install gofer@beta will install 3.x.