upgrade to bluebird 3 and minor cleanup

groupon / node-cached

A simple caching library for node.js, inspired by the Play cache API

BSD 3-Clause "New" or "Revised" License

94 stars 15 forks source link

upgrade to bluebird 3 and minor cleanup #17

Closed ghost closed 9 years ago

ghost commented 9 years ago

Investigating a bug in our app - did some upgrading & adding a test to check for memcached 1MB object size limit

jkrems commented 9 years ago

Is it really a concern for cached that 1MB happens to be the default setting for max values in memcached? Trying to understand what the additional test is testing. :)

ghost commented 9 years ago

No you're totally right - this was originally put up to test behavior so I could debug the problem with the app using this package.

I've since removed the test code.

jkrems commented 9 years ago

LGTM