search

groupon / node-cached

A simple caching library for node.js, inspired by the Play cache API
BSD 3-Clause "New" or "Revised" License
94 stars 15 forks source link

Definition types #54

Open Juraj-Masiar opened 3 years ago

Juraj-Masiar commented 3 years ago

Hello, I've just created definition types pull request for this project: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/50491

If you know what that actually is and if you have time, feel free to check it out! This is the first time I've created definition types for a project and I have to say it took me much longer than I expected. Especially considering the super simple API here...

I will close this issue once it gets merged. If someone wants to be co-author, please let me know! More info about being an owner here.

Juraj-Masiar commented 3 years ago

Hello again, I've updated TypeScript definition files for the version 6. If someone wants to review it or upgrade it, please do so: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/55292/files

I'm no expert on definition files so I'm pretty sure there is room for improvement. I've only tested in on my own use-case where it works fine (better than before). Thanks!