search

groupon / selenium-download

allow downloading of latest selenium standalone server and chromedriver
BSD 3-Clause "New" or "Revised" License
28 stars 25 forks source link

Upgrade to selenium version compatible with latest Firefox #14

Closed jkrems closed 10 years ago

johan commented 10 years ago

LGTM.

EndangeredMassa commented 10 years ago

published in 1.2.2

johan commented 10 years ago

Does this need unpublishing?

It probably needs its own testium test suite.

jkrems commented 10 years ago

Not sure what you mean - this is what was unpublished. The funny thing is: it was tested against testium2 at least and worked fine.

jkrems commented 10 years ago

But, on a related note: I'd appreciate a re-publish (e.g. with a major bump) so I can switch testium2 back to a proper version of selenium-download. :)

EndangeredMassa commented 10 years ago

I tested it before publishing and it worked fine. Ugh.

I'd rather not publish a known bad version, even if we do plan to update it. I can, but it just feels wrong.

jkrems commented 10 years ago

Ah, got what makes this a "bad version": https://code.google.com/p/selenium/issues/detail?id=8102

I never tested it in combination with phantomjs since testium2 launches phantomjs directly.

EndangeredMassa commented 10 years ago

I hope this is fixed soon and we can simply bump to the next version. =/