search

groupon / selenium-download

allow downloading of latest selenium standalone server and chromedriver
BSD 3-Clause "New" or "Revised" License
28 stars 25 forks source link

Dependencies out of date (warnings in console) #23

Closed nelsonic closed 7 years ago

nelsonic commented 8 years ago

Hi! When I install this module from npm I see the following warnings in terminal:

groupon-selenium-download-warning-when-installing

It appears that the dependencies are out-of-date: https://david-dm.org/groupon/selenium-download Dependency Status

Would you accept a PR updating them? (or is there a reason they are not updated to latest versions?) Thanks!

nelsonic commented 8 years ago

Also, there is a mixture of Tilde (~) and Caret (^) in the package.json is this intentional Tilde vs. Caret: https://nodesource.com/blog/semver-tilde-and-caret/

jkrems commented 8 years ago

Yes, we use ~ or 0.x dependencies and ^ for anything 1.x+. The semantics of ^ for anything before 1.0.0 are somewhat confusing, especially for newcomers. I've had multiple people who assumed ^0.8.0 would include ^0.9.0.

So since ^0.x means the same thing a ~0.x, we use the latter.

jkrems commented 8 years ago

Oh, sorry, forgot about the actual issue test. There's no particular reason we don't update the dependencies. I'll throw that into the current PR.

jkrems commented 8 years ago

Actually, we'll have to punt on this until mocha@3 is published. Apparently it's still not on npm (?)

nelsonic commented 7 years ago

@jkrems thanks! 🎉 (hope your week is going well!)

jkrems commented 7 years ago

Sure thing! Sorry for the long delay. :)