search

groupon / webdriver-http-sync

sync http implementation of the WebDriver protocol for Node.js
BSD 3-Clause "New" or "Revised" License
39 stars 15 forks source link

How to contribute? #21

Closed azu closed 9 years ago

azu commented 9 years ago

Hi, I want to implement Element.prototype.getElement and Element.prototype.getElements.

/session/:sessionId/element/:id/element
/session/:sessionId/element/:id/elements

But, this repogitory contain only implementation without tests.
Related issue: #3

Do I create the pull-request which is contain only implementation to this repo? (Additionally, I create the pull-request which is contain only tests to Testium)

How to contribute to webdriver-http-sync?

Aside:

I think we need these method for using PageObject pattern.

Real use-case : Refactoring test by page object by azu · Pull Request #2 · coding-kata/todo-app-jquery-to-backbone

EndangeredMassa commented 9 years ago

To test this app, I run the testium test suite linked to the modified webdriver-http-sync code. For now, I'm fine adding tests to testium for changes here. Usually, changes here mean changes in testium anyway. But yes, it would be best if this project had its own test suite.

Page Objects are a fine pattern, but they belong in the applications using testium, exactly as you have already done. I don't know what we can add to testium itself to take advantage of page objects.