search

grovesNL / glow

GL on Whatever: a set of bindings to run GL anywhere and avoid target-specific code
Apache License 2.0
1.21k stars 130 forks source link

Fix some rust FFI #319

Closed sagudev closed 1 month ago

sagudev commented 1 month ago

Discovered and verified on https://github.com/servo/servo/pull/33918

as * casts are dangerous. Each commit is standalone and documented.

sagudev commented 1 month ago

Looks good, generally. How strong do you feel about the indexing starting at 1? I think my preference would be zero.

What indexing?

tronical commented 1 month ago

Sorry :) wrong comment on wrong GitHub issue :). Please discard.

sagudev commented 1 month ago

gentle ping @grovesNL