tangmi commented 5 years ago

Closes #107. This changeset is mostly based off get_member_name.

I hope I updated everything correctly!

Ran bindings_generator
Ran the command that wasm executes (I couldn't get wasm to run directly)
Implement get_name in bindings_wasm_funcsions
Add usage to glsl_tests.rs

codecov[bot] commented 5 years ago

Codecov Report

Merging #108 into master will decrease coverage by 3.05%. The diff coverage is 92.3%.

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   49.84%   46.78%   -3.06%     
==========================================
  Files           7        7              
  Lines        1575     1261     -314     
==========================================
- Hits          785      590     -195     
+ Misses        790      671     -119

Impacted Files	Coverage Δ
spirv_cross/src/bindings_native.rs	`0.34% <ø> (-0.24%)`	:arrow_down:
spirv_cross/src/spirv.rs	`32.28% <100%> (-2.32%)`	:arrow_down:
spirv_cross/src/compiler.rs	`77.07% <90%> (-5.1%)`	:arrow_down:
spirv_cross/src/msl.rs	`46.36% <0%> (-8.76%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d6a065...b38f4ad. Read the comment docs.

bors[bot] commented 5 years ago

grovesNL / spirv_cross

feat: expose Compiler::get_name #108

Codecov Report

Build succeeded