Update to more recent upstream?

grovesNL / spirv_cross

Safe Rust wrapper around SPIRV-Cross

Apache License 2.0

86 stars 42 forks source link

Update to more recent upstream? #165

Closed mkeeter closed 3 years ago

mkeeter commented 3 years ago

I recently ran into this issue when writing code using wgpu-native.

Any interest in updating the spirv_cross crate to the most recent upstream? I'm happy to test whether a simple submodule bump works, or whether more of the API has changed.

Pushing the fix all the way downstream to wgpu-native is going to be a challenge, as I think it goes through

spirv_cross
gfx backends
gfx-hal proper
wgpu-core
wgpu-native

But having an updated spirv_cross is the first step!

grovesNL commented 3 years ago

Sure, no problem. I just published 0.23 because there were some small breaking changes since the last release. We could've managed a patch release for spirv_cross, but it's useful to get the breaking changes into gfx anyway.

We currently pin wgpu-core's master branch to git commits of gfx and regularly update it, so we can probably propagate this to wgpu-native's master branch pretty quickly.

mkeeter commented 3 years ago

Awesome, thanks!