growexx / react-user-boilerplate

React Boilerplate for user portal. Includes Ant Design Component, Styled-Component, etc.
MIT License
0 stars 0 forks source link

Feature/two factor authentication #55

Closed pratibha-growexxer closed 3 years ago

pratibha-growexxer commented 3 years ago
Maulik-growexxer commented 3 years ago

@pratibha-growexxer can you please fix the conflict?

remind me? did we decide to merge this in main? let's say if we merge it is there any way to decouple the code quickly if we don't want OPT feature?

pratibha-growexxer commented 3 years ago

@pratibha-growexxer can you please fix the conflict?

remind me? did we decide to merge this in main? let's say if we merge it is there any way to decouple the code quickly if we don't want OPT feature?

@Maulik-growexxer We did not had the discussion on weather we should merge it or not. If we are merging it, we just have to delete two folders:

  1. Auth/TwofactorAuthentication
  2. components/OtpComponent

Other changes will be to just remove the route and add login logic to login saga instead of otpcomponent's saga.

I think it's easy to do as everything is differentiated, it won;t create much problem to decouple.

pratibha-growexxer commented 3 years ago

@Maulik-growexxer removed conflicts