search

growth-astro / growth-too-marshal

GROWTH Target of Opportunity Marshal
MIT License
13 stars 12 forks source link

update ztf references #111

Closed mcoughlin closed 4 years ago

mcoughlin commented 4 years ago

Does this pull request make any changes to the database? None

Code changes that affect the database require special attention for data migration. If your change affects the database, describe the migration plan here.

lpsinger commented 4 years ago

Would you please explain what this change does?

mcoughlin commented 4 years ago

Uses Frank's dedicated ToO reference limits.

lpsinger commented 4 years ago

Is this going to be a permanent change? If so, we need not keep the old code.

mcoughlin commented 4 years ago

I think that the future of this is ambiguous enough (read, political disagreement) that it's worth having the original as well for now.

lpsinger commented 4 years ago

OK, but the format of the output is the same? So instead of copy-pasting the entire task, can we just comment out the old scraping code?

mcoughlin commented 4 years ago

yes we can do whatever you like. commented out or not, i am happy.

lpsinger commented 4 years ago

OK, would you please remove the new task, comment out the old scraping code, and add the new scraping code?

lpsinger commented 4 years ago

BTW, please rebase from master to get the latest unit test fixes.

lpsinger commented 4 years ago

Please rebase with master so that we can see if the unit tests pass.