search

growthbook / growthbook-sdk-java

The Java SDK for GrowthBook (JVM, Android)
https://docs.growthbook.io/lib/java
MIT License
7 stars 10 forks source link

Logging #58

Closed vazarkevych closed 1 month ago

vazarkevych commented 1 month ago

printStackTrace() was replaced with logging

igorlovich commented 1 month ago

Any reason not to use Slf4j (as proposed in https://github.com/growthbook/growthbook-sdk-java/pull/24) so that users can pick whatever logging backend they want (including java logging) ?

nnusse commented 1 month ago

I can only support @igorlovich. The SDK is now highly coupled to the java based logging implementation. That would mean that every consumer/user of the SDK has to provide additional configuration to change the message format or other properties, although they might have these configuration already in place - but for the logging framework that they have in use, like Log4j or Logback. Using SLF4J would avoid all these conflicts.

Bohdan-Kim commented 1 month ago

So, we need to add SLF4J