Start using gorelease (https://godoc.org/golang.org/x/exp/cmd/gorelease)

grpc-ecosystem / go-grpc-middleware

Golang gRPC Middlewares: interceptor chaining, auth, logging, retries and more.

Apache License 2.0

6.33k stars 697 forks source link

Start using gorelease (https://godoc.org/golang.org/x/exp/cmd/gorelease) #344

Open bwplotka opened 4 years ago

bwplotka commented 4 years ago

Pulled from https://github.com/grpc-ecosystem/go-grpc-middleware/issues/275 for visibility.

drewwells commented 3 years ago

This is a nifty tool. Can you elaborate on expected features?

gorelease -base=v1 tag -version=???

bwplotka commented 3 years ago

Maybe @johanbrandhorst has ideas? I never used gorelease and also we don't build binaries in this project, so what we can leverage? (:

johanbrandhorst commented 3 years ago

gorelease is different from goreleaser, which builds binaries. gorelease maintains a compatibility promise. We use it in the grpc-gateway, and we could use it here too.

drewwells commented 3 years ago

I could see a few uses for this:

Evaluate compliance with v1 (is not required but is helpful for documentation)
Evaluate each new PR in v2 against v2 to determine if API promises were broken grpc-gateway does this

I'm guessing that the latter is the desired use of this tool. Since v2 is still undergoing API changes, we can't enforce this as a build check. So is the intention to add this as a new github action workflow that will get marked required after the API is settled?