grpc-ecosystem / go-grpc-middleware

Golang gRPC Middlewares: interceptor chaining, auth, logging, retries and more.
Apache License 2.0
6.33k stars 697 forks source link

Example will log only first field #691

Open Gregmus2 opened 10 months ago

Gregmus2 commented 10 months ago

https://github.com/grpc-ecosystem/go-grpc-middleware/blob/220740bc30b1fb92c6a36f3ac3c248ad0c5cc53d/interceptors/logging/examples/logrus/example_test.go#L21

if statement should be replaced with for in order to log all fields

johanbrandhorst commented 10 months ago

I thought we fixed this already, maybe it was in a different logger 🤔 . Would you be interested in contributing a fix?

arckadious commented 10 months ago

I had the same issue, I'll try to fix it !

arckadious commented 10 months ago

https://github.com/grpc-ecosystem/go-grpc-middleware/pull/694