feat: add `grpc_code` label to `grpc_server_handling_seconds` metric

grpc-ecosystem / go-grpc-middleware

Golang gRPC Middlewares: interceptor chaining, auth, logging, retries and more.

Apache License 2.0

6.26k stars 690 forks source link

feat: add `grpc_code` label to `grpc_server_handling_seconds` metric #709

Open miparnisari opened 4 months ago

miparnisari commented 4 months ago

Changes

Address https://github.com/grpc-ecosystem/go-grpc-middleware/issues/606

Mostly copied over from https://github.com/jon-whit/go-grpc-prometheus/commit/b8b08287c8938a1cb099443c0c79d10ea60201c6

Verification

Unit tests pass

johanbrandhorst commented 4 months ago

Hi, I can see this PR is left as a draft, do you intend to open an issue to discuss the addition of these metrics? I would prefer discussing additions in an issue before reviewing any implementation.

miparnisari commented 4 months ago

Hey @johanbrandhorst, we can discuss in the issue that already exists? #606