search

grpc-ecosystem / go-grpc-middleware

Golang gRPC Middlewares: interceptor chaining, auth, logging, retries and more.
Apache License 2.0
6.26k stars 690 forks source link

Go version support policy? #717

Open akshayjshah opened 3 months ago

akshayjshah commented 3 months ago

Does this repository have an explicit policy on Go version support? I notice that CI is only testing on Go 1.19 and 1.20, neither of which is still receiving security patches. At this point, testing on 1.19 is beginning to block some version updates.

Would it be okay if I opened a PR updating to the latest versions of the various Github actions and changing CI to test on stable and oldstable? They were introduced relatively recently in the setup-go as aliases for the two currently-supported versions of Go.

johanbrandhorst commented 3 months ago

Using stable and oldstable sounds ideal to me :). Please feel free to submit a PR!

ash2k commented 1 month ago

Go version support is documented here: https://github.com/grpc-ecosystem/go-grpc-middleware?tab=readme-ov-file#prerequisites

I've just bumped the minimum version to 1.21 and added 1.22 and 1.23 to CI in https://github.com/grpc-ecosystem/go-grpc-middleware/pull/721. Did I miss something or we can close this issue?

johanbrandhorst commented 1 month ago

This issue is newer than the existing policy, it might be nice to switch to just stable and oldstable.