grpc-ecosystem / go-grpc-middleware

Golang gRPC Middlewares: interceptor chaining, auth, logging, retries and more.
Apache License 2.0
6.26k stars 690 forks source link

Protovalidate interceptor cleanup, Go version bump #721

Closed ash2k closed 1 month ago

ash2k commented 1 month ago

Changes

Please see individual commits.

Verification

Unit tests. No significant changes.

ash2k commented 1 month ago

Follow up questions:

johanbrandhorst commented 1 month ago
* I have a custom codec that I use with gRPC. It handles both proto and non-proto (a single type) messages. I'd like to use the protovalidate interceptors with it. Would you accept a feature to specify a list of Go types (as `reflect.Type`) to ignore, instead of erroring on them.

No, I'd rather users create their own interceptors for this sort of thing.

* Would you accept a PR with client validating interceptors?

For outgoing requests? For responses from servers? Not sure where that would go.

johanbrandhorst commented 1 month ago

Thanks for your contribution!

ash2k commented 1 month ago

Thank you!