Dirty build, version not from tag

grpc-ecosystem / grpc-health-probe

A command-line tool to perform health-checks for gRPC applications in Kubernetes and elsewhere

Apache License 2.0

1.44k stars 188 forks source link

Closed stefanb closed 1 year ago

stefanb commented 1 year ago

It seems that at least the most recent release build 1.4.20 had some changes when being built, thanks to the new -version tag since #146:

grpc_health_probe -version
commit 01a57ee14c88d59caf24a08da75a62f2d47080bc (dirty)

Hash 01a57ee14c88d59caf24a08da75a62f2d47080bc points to the correct tag, so the release should (also?) show tag "v1.4.20".

ahmetb commented 1 year ago

Awkward. I will take a look.

stefanb commented 1 year ago

There are basically 2 related issues:

Bug: "dirty" label, probably a bug in the release workflow or goreleaser config.
Feature: show label instead of (or in addition to) git hash (after checking the discussion at #146 labels were not even suppose to be supported yet).