grpc-ecosystem / grpc-health-probe

A command-line tool to perform health-checks for gRPC applications in Kubernetes and elsewhere
Apache License 2.0
1.44k stars 188 forks source link

feat(deps): bump to go 1.22 for cve-2023-45288 #189

Closed defgenx closed 7 months ago

defgenx commented 7 months ago

Description

Fixes #188.

ahmetb commented 7 months ago

Can you also update .github/workflows files please?

defgenx commented 7 months ago

Can you also update .github/workflows files please?

Looks like github workflows are already in go 1.22. Maybe I don't understand what you're asking me to do :').

defgenx commented 7 months ago

I just modified how I applied the deps update to stick with how it was done until now.

I think bumping the go version is useless (it can be a problem for people using it with old go versions). We just need to merge a PR from dependabot (or any other one reviewed and ready to be merged) and tag it to use the last go version released.

If you do that I can quickly test the new release you'll publish and then close this PR and the linked issue if it works.

defgenx commented 7 months ago

Is it possible for a maintainer to read my last comment ? 🙇