search

grpc-ecosystem / grpc-httpjson-transcoding

Transcoding to provide HTTP/JSON interface for gRPC Service
Apache License 2.0
164 stars 35 forks source link

remove custom and apparently unused zlib #104

Closed asedeno closed 1 month ago

asedeno commented 1 month ago

This appears to be used by @com_google_protobuf, but it brings in a newer version anyhow.

google-oss-prow[bot] commented 1 month ago

Hi @asedeno. Thanks for your PR.

I'm waiting for a grpc-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
TAOXUY commented 1 month ago

/ok-to-test

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asedeno, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/grpc-ecosystem/grpc-httpjson-transcoding/blob/master/OWNERS)~~ [TAOXUY] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment