search

grpc-ecosystem / grpc-httpjson-transcoding

Transcoding to provide HTTP/JSON interface for gRPC Service
Apache License 2.0
164 stars 35 forks source link

Expose last parsed delimiter in MessageReader #58

Closed nareddyt closed 3 years ago

nareddyt commented 3 years ago

Currently, MessageReader::NextMessage will advance the buffer past the gRPC delimiter.

However, we need the delimiter if we wish to preserve the original message. Instead of having our extraction libraries reform the delimiter, just rely on MessageReader to expose the last parsed message.

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nareddyt, qiwzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/grpc-ecosystem/grpc-httpjson-transcoding/blob/master/OWNERS)~~ [nareddyt,qiwzhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment