search

grpc-ecosystem / grpc-httpjson-transcoding

Transcoding to provide HTTP/JSON interface for gRPC Service
Apache License 2.0
164 stars 35 forks source link

Remove usage of google::protobuf::util::error. #59

Closed benjaminp closed 3 years ago

benjaminp commented 3 years ago

This is needed to be compatible with protobuf 3.16.0.

google-oss-robot commented 3 years ago

Hi @benjaminp. Thanks for your PR.

I'm waiting for a grpc-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qiwzhang commented 3 years ago

/ok-to-test

qiwzhang commented 3 years ago

Tested failed with following errors:

[0 / 151] [Prepa] Writing file src/libmessage_stream.a-2.params ERROR: /home/prow/go/src/github.com/grpc-ecosystem/grpc-httpjson-transcoding/src/BUILD:82:11: Compiling src/request_message_translator.cc failed: (Exit 1): clang-10 failed: error executing command /usr/bin/clang-10 -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 40 argument(s) skipped) Use --sandbox_debug to see verbose messages from the sandbox clang-10 failed: error executing command /usr/bin/clang-10 -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 40 argument(s) skipped) Use --sandbox_debug to see verbose messages from the sandbox src/request_message_translator.cc:136:33: error: no member named 'StatusCode' in namespace 'google::protobuf::util' ::google::protobuf::util::StatusCode::kInvalidArgument,


src/request_message_translator.cc:144:33: error: no member named 'StatusCode' in namespace 'google::protobuf::util'
      ::google::protobuf::util::StatusCode::kInvalidArgument,
      ~~~~~~~~~~~~~~~~~~~~~~~~~~^
src/request_message_translator.cc:153:33: error: no member named 'StatusCode' in namespace 'google::protobuf::util'
      ::google::protobuf::util::StatusCode::kInvalidArgument,
      ~~~~~~~~~~~~~~~~~~~~~~~~~~^
3 errors generated.
benjaminp commented 3 years ago

yeah, seems like this doesn't work on protobuf 3.15.0series...

qiwzhang commented 3 years ago

You can upgrade it here

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminp, qiwzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/grpc-ecosystem/grpc-httpjson-transcoding/blob/master/OWNERS)~~ [qiwzhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment