search

grpc-ecosystem / grpc-httpjson-transcoding

Transcoding to provide HTTP/JSON interface for gRPC Service
Apache License 2.0
164 stars 35 forks source link

b/208716168: allow path matcher to always check custom verb #66

Closed TAOXUY closed 2 years ago

TAOXUY commented 2 years ago

Right now, the path matcher only match the registered custom verb. If it is unregistered and the trailing segment is wildcard, it will be part of that, causing a mismatch. For example, /foo/{x=*} will matches /foo/random:verb, where x is bound to random:verb.

Add an option to always match the custom verb.

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nareddyt, qiwzhang, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/grpc-ecosystem/grpc-httpjson-transcoding/blob/master/OWNERS)~~ [TAOXUY,nareddyt,qiwzhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment