search

grpc-ecosystem / grpc-httpjson-transcoding

Transcoding to provide HTTP/JSON interface for gRPC Service
Apache License 2.0
164 stars 35 forks source link

Fix benchmark for gRPC streaming message builder logic to use std::stringstream #83

Closed orionHong closed 2 years ago

orionHong commented 2 years ago

absl::StrAppend is not suitable for appending large string, which will cause the benchmark script to crash.

google-oss-prow[bot] commented 2 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

google-oss-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nareddyt, orionHong, qiwzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/grpc-ecosystem/grpc-httpjson-transcoding/blob/master/OWNERS)~~ [nareddyt,orionHong,qiwzhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 2 years ago

New changes are detected. LGTM label has been removed.