grpc-ecosystem / grpc-opentracing

OpenTracing is a set of consistent, expressive, vendor-neutral APIs for distributed tracing and context propagation
BSD 3-Clause "New" or "Revised" License
472 stars 98 forks source link

Add a optional tracer implementation loader. #10

Closed wu-sheng closed 7 years ago

wu-sheng commented 7 years ago
  1. Sync the OT version up-to-date, 0.20.4
  2. Sync the gprc version up-to-date, 1.0.2
  3. Add a TracerLoader to get tracer instance by spi. It just a optional choose.
wu-sheng commented 7 years ago

@bensigelman , I can't choose a reviewer, just @ you instead.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


wu-sheng commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

wu-sheng commented 7 years ago

@bensigelman , updated. But the comments on README are very easy, just mention the spi mechanism. I think maybe it's enough, because it's just optional.

wu-sheng commented 7 years ago

@bensigelman , is there anything else to change?