search

grpc-ecosystem / grpc-opentracing

OpenTracing is a set of consistent, expressive, vendor-neutral APIs for distributed tracing and context propagation
BSD 3-Clause "New" or "Revised" License
472 stars 98 forks source link

Interceptors for Python, Node and other languages #11

Open Malayks opened 7 years ago

Malayks commented 7 years ago

Hello, I have been extensively using the GO-gRPC interceptor to trace few microservices written in go and using gRPC but I have a need to create a py and node service and was wondering if we have any interceptors for python and Javascript so that my polyglot environment is fully traced.

If not I would like to know how can I write my own. Any reference or documentation which can help me write the interceptors for py and js similar to the ones we have fro go and java

bhs commented 7 years ago

@Malayks we would very much value the contributions. Last time I checked, the GRPC-python API did not support interceptors natively, and that was the blocker there. I did not check Javascript.

Could you take a look at the GRPC APIs and report back here? I can apply some gentle pressure to the GRPC-team if the APIs are not sufficient to do the actual interception... they really should be! Thanks.

Malayks commented 7 years ago

@bensigelman I took a quick look and could not find native support for interceptors in Node GRPC APIs, did not investigate Python as Node is a priority for me.

bhs commented 7 years ago

@Malayks I added something to the tail of https://github.com/grpc/grpc/issues/8767#issuecomment-273027261 ... feel free to weigh in if you feel like it :)

Malayks commented 7 years ago

Thanks @bensigelman. Looks like for the time being, writing a wrapper is the only option.